drm/amdgpu: Fix use-after-free in amdgpu_cs_ioctl
authorYuBiao Wang <YuBiao.Wang@amd.com>
Wed, 24 Aug 2022 07:56:04 +0000 (15:56 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 30 Aug 2022 21:00:03 +0000 (17:00 -0400)
commit3c93603d9568c7c4b20ff1712ddc60e997d78df7
treef64cd7881ec0d07cef4560718494a58c89bb413a
parentd1b4a51a4ca8954f30cf4671b25c4f8637c45600
drm/amdgpu: Fix use-after-free in amdgpu_cs_ioctl

[Why]
In amdgpu_cs_ioctl, amdgpu_job_free could be performed ealier if there
is -ERESTARTSYS error. In this case, job->hw_fence could be not
initialized yet. Putting hw_fence during amdgpu_job_free could lead to a
use-after-free warning.

[How]
Check if drm_sched_job_init is performed before job_free by checking
s_fence.

v2: Check hw_fence.ops instead since it could be NULL if fence is not
initialized. Reverse the condition since !=NULL check is discouraged in
kernel.

Signed-off-by: YuBiao Wang <YuBiao.Wang@amd.com>
Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c