Set DisableImplicitFrameworkReferences for all projects (dotnet/corefx#34786)
authorEric StJohn <ericstj@microsoft.com>
Fri, 25 Jan 2019 16:59:14 +0000 (08:59 -0800)
committerGitHub <noreply@github.com>
Fri, 25 Jan 2019 16:59:14 +0000 (08:59 -0800)
commit3c611674cdc792c045046712c1b7379049ff7b51
treecb248a56bc800731d1fb2f1d34b02b0d6c84e792
parent31a30176913812d8335fa3885d82ace6ca2ea7e9
Set DisableImplicitFrameworkReferences for all projects (dotnet/corefx#34786)

* Set DisableImplicitFrameworkReferences for all projects

The SDK added targets which require the assets file when framework reference items are set.

We can disable the implicit FrameworkReference item in order to prevent these from running.

* Don't rely on implicit VB imports

DisableImplicitFrameworkReferences also doubles as DisableImplicitNamespaceImports.

Rather than enable this I think it's better just to stop relying on the default imports.

* Add missing reference to EventLog

Commit migrated from https://github.com/dotnet/corefx/commit/6653c5fe2adc7c7fca962df3fdc6675354726951
18 files changed:
eng/depProj.targets
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft.VisualBasic.Core.vbproj
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/FileIO/FileSystem.Windows.vb
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/FileIO/FileSystem.vb
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/FileIO/MalformedLineException.vb
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/FileIO/SpecialDirectories.vb
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/FileIO/TextFieldParser.vb
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/Helpers/NativeMethods.Windows.vb
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/Helpers/NativeTypes.vb
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/Helpers/UnsafeNativeMethods.vb
src/libraries/Microsoft.VisualBasic.Core/tests/VB/FileIOTestBase.vb
src/libraries/Microsoft.VisualBasic.Core/tests/VB/FileIOTests.vb
src/libraries/Microsoft.VisualBasic.Core/tests/VB/Helpers.vb
src/libraries/Microsoft.VisualBasic.Core/tests/VB/Microsoft.VisualBasic.VB.Tests.vbproj
src/libraries/Microsoft.VisualBasic.Core/tests/VB/SpecialDirectoriesTests.vb
src/libraries/Microsoft.VisualBasic.Core/tests/VB/TextFieldParserTests.vb
src/libraries/System.Diagnostics.EventLog/ref/System.Diagnostics.EventLog.csproj
src/libraries/System.Diagnostics.EventLog/src/System.Diagnostics.EventLog.csproj