tty: serial: omap_serial: line is unsigned, don't check < 0
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 12 Nov 2014 09:28:34 +0000 (10:28 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Nov 2014 01:06:39 +0000 (17:06 -0800)
commit3c59958d5868f77741930402dfcb27e9dc8968d2
tree0eb341aa885ad19ef7fdfce3fa79bea8249a9cdf
parent54178fe6b3443249ec2dcd6eec9f2c3ebcdc3142
tty: serial: omap_serial: line is unsigned, don't check < 0

Dan Carpenter reported:
|drivers/tty/serial/8250/8250_omap.c:1025 omap8250_probe()
|warn: unsigned 'up.port.line' is never less than zero.
|1025          if (up.port.line < 0) {

Since of_alias_get_id() and pdev->id can get negative I check for the
error via ret variable.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/omap-serial.c