ASoC: pcm512x: Fix a double unlock in pcm512x_digital_mute()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 21 Dec 2018 09:11:20 +0000 (12:11 +0300)
committerpopcornmix <popcornmix@gmail.com>
Mon, 13 May 2019 23:08:19 +0000 (00:08 +0100)
commit3c105ab92a48ba1d2e3e4cc60cb020531519f5f4
tree1073c18faaeba3141107a724bc12dc972635dd3f
parenta9f347f26afa4f244bbce16ed19f26ed57516919
ASoC: pcm512x: Fix a double unlock in pcm512x_digital_mute()

[ Upstream commit 28b698b7342c7d5300cfe217cd77ff7d2a55e03d ]

We accidentally call mutex_unlock(&pcm512x->mutex); twice in a row.

I re-wrote the error handling to use "goto unlock;" instead of returning
directly.  Hopefully, it makes the code a little simpler.

Fixes: 3500f1c589e9 ("ASoC: pcm512x: Implement the digital_mute interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviwed-by: Dimitris Papavasiliou <dpapavas@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/pcm512x.c