efi: Only print errors about failing to get certs if EFI vars are found
authorJavier Martinez Canillas <javierm@redhat.com>
Mon, 17 Feb 2020 11:39:47 +0000 (12:39 +0100)
committerMimi Zohar <zohar@linux.ibm.com>
Tue, 18 Feb 2020 12:35:48 +0000 (07:35 -0500)
commit3be54d558c75562e42bc83d665df024bd79d399b
treef8949427089e09acd45ed4254427521dc840cd1c
parentff5ac61ee83c13f516544d29847d28be093a40ee
efi: Only print errors about failing to get certs if EFI vars are found

If CONFIG_LOAD_UEFI_KEYS is enabled, the kernel attempts to load the certs
from the db, dbx and MokListRT EFI variables into the appropriate keyrings.

But it just assumes that the variables will be present and prints an error
if the certs can't be loaded, even when is possible that the variables may
not exist. For example the MokListRT variable will only be present if shim
is used.

So only print an error message about failing to get the certs list from an
EFI variable if this is found. Otherwise these printed errors just pollute
the kernel log ring buffer with confusing messages like the following:

[    5.427251] Couldn't get size: 0x800000000000000e
[    5.427261] MODSIGN: Couldn't get UEFI db list
[    5.428012] Couldn't get size: 0x800000000000000e
[    5.428023] Couldn't get UEFI MokListRT

Reported-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
security/integrity/platform_certs/load_uefi.c