ethtool: always write dev in ethnl_parse_header_dev_get
authorJakub Kicinski <kuba@kernel.org>
Tue, 14 Dec 2021 15:47:25 +0000 (07:47 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 15 Dec 2021 15:09:24 +0000 (15:09 +0000)
commit3bc14ea0d12a57a968038f8e86e9bc2c1668ad9a
tree4a7268ff8d2517e67471382a53d669a7c63546d8
parentf1d9268e061863ead77b07f5a6807d063e28a1c2
ethtool: always write dev in ethnl_parse_header_dev_get

Commit 0976b888a150 ("ethtool: fix null-ptr-deref on ref tracker")
made the write to req_info.dev conditional, but as Eric points out
in a different follow up the structure is often allocated on the
stack and not kzalloc()'d so seems safer to always write the dev,
in case it's garbage on input.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ethtool/netlink.c