scsi: ibmvscsi: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Wed, 17 May 2023 14:34:09 +0000 (14:34 +0000)
committerKees Cook <keescook@chromium.org>
Fri, 26 May 2023 20:52:18 +0000 (13:52 -0700)
commit3b92d34ac06a4bb05a349641cb22373f1ae33f0b
treede98c9aba3092f5528a238a42333a89560ef1c94
parent883f8fe87686d1deef2614b1d3a23ca7e5193dff
scsi: ibmvscsi: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230517143409.1520298-1-azeemshaikh38@gmail.com
drivers/scsi/ibmvscsi/ibmvscsi.c