stream: remove lowWaterMark feature
authorisaacs <i@izs.me>
Thu, 21 Feb 2013 18:51:15 +0000 (10:51 -0800)
committerisaacs <i@izs.me>
Thu, 21 Feb 2013 23:23:18 +0000 (15:23 -0800)
commit3b2e9d26480da0c73a3735314bee5910cb3844ab
tree55b9f481fa21d2a30fa39805fb0c9f8a279196dd
parent089ec586135726e82dc0d25c2e328478d577db24
stream: remove lowWaterMark feature

It seems like a good idea on the face of it, but lowWaterMarks are
actually not useful, and in practice should always be set to zero.

It would be worthwhile for writers if we actually did some kind of
writev() type of thing, but actually this just delays calling write()
and the overhead of doing a bunch of Buffer copies is not worth the
slight benefit of calling write() fewer times.
19 files changed:
doc/api/stream.markdown
doc/blog/feature/streams2.md
lib/_stream_readable.js
lib/_stream_transform.js
lib/_stream_writable.js
lib/fs.js
lib/tty.js
lib/zlib.js
src/node.js
test/simple/test-file-write-stream.js
test/simple/test-file-write-stream2.js
test/simple/test-fs-read-stream-err.js
test/simple/test-fs-write-stream-err.js
test/simple/test-net-binary.js
test/simple/test-stream2-basic.js
test/simple/test-stream2-objects.js
test/simple/test-stream2-push.js
test/simple/test-stream2-transform.js
test/simple/test-stream2-writable.js