net: dsa: sja1105: Don't return a negative in u8 sja1105_stp_state_get
authorVladimir Oltean <olteanv@gmail.com>
Wed, 8 May 2019 20:32:25 +0000 (23:32 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 May 2019 20:57:50 +0000 (13:57 -0700)
commit3b2c4f4d63a554739a32dc709b617f2d2acc2ad0
tree028b795ab13f1f3144e31a528eadfe4e74655b13
parent5425711b6dd0f7283202729863d9210e7a1c7cd2
net: dsa: sja1105: Don't return a negative in u8 sja1105_stp_state_get

Dan Carpenter says:

The patch 640f763f98c2: "net: dsa: sja1105: Add support for Spanning
Tree Protocol" from May 5, 2019, leads to the following static
checker warning:

        drivers/net/dsa/sja1105/sja1105_main.c:1073 sja1105_stp_state_get()
        warn: signedness bug returning '(-22)'

The caller doesn't check for negative errors anyway.

Fixes: 640f763f98c2: ("net: dsa: sja1105: Add support for Spanning Tree Protocol")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/sja1105/sja1105_main.c