[InstCombine] canonicalize min/max constant to select's false value
authorSanjay Patel <spatel@rotateright.com>
Mon, 21 Nov 2016 22:04:14 +0000 (22:04 +0000)
committerSanjay Patel <spatel@rotateright.com>
Mon, 21 Nov 2016 22:04:14 +0000 (22:04 +0000)
commit3b0bafee6320277cf9daafa93bf9a612ea882882
tree638040fc139ca5e8b0d807f3c0ba2179f1a7bdc4
parent8efbe6acaeaa8ce0fed7d710d3ccb48823a672f8
[InstCombine] canonicalize min/max constant to select's false value

This is a first step towards canonicalization and improved folding/codegen
for integer min/max as discussed here:
http://lists.llvm.org/pipermail/llvm-dev/2016-November/106868.html

Here, we're just matching the simplest min/max patterns and adjusting the
icmp predicate while swapping the select operands.

I've included FIXME tests in test/Transforms/InstCombine/select_meta.ll
so it's easier to see how this might be extended (corresponds to the TODO
comment in the code). That's also why I'm using matchSelectPattern()
rather than a simpler check; once the backend is patched, we can just
remove some of the restrictions to allow the obfuscated min/max patterns
in the FIXME tests to be matched.

Differential Revision: https://reviews.llvm.org/D26525

llvm-svn: 287585
llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
llvm/test/Transforms/InstCombine/adjust-for-minmax.ll
llvm/test/Transforms/InstCombine/div-shift.ll
llvm/test/Transforms/InstCombine/minmax-fold.ll
llvm/test/Transforms/InstCombine/pr27236.ll
llvm/test/Transforms/InstCombine/select_meta.ll
llvm/test/Transforms/InstCombine/sext.ll