pvr: Remove PVR_WINSYS_BO_FLAG_ZERO_ON_ALLOC flag
authorVlad Schiller <vlad-radu.schiller@imgtec.com>
Thu, 10 Aug 2023 12:14:38 +0000 (13:14 +0100)
committerMarge Bot <emma+marge@anholt.net>
Wed, 6 Sep 2023 12:19:46 +0000 (12:19 +0000)
commit3a949de28c42d8714320e56bd99168148503da7d
treecae595f5e6b1dfc5f23a4648656265a251bcec33
parenta57faf50370f60e06e03062b0ff4a0c2c3258004
pvr: Remove PVR_WINSYS_BO_FLAG_ZERO_ON_ALLOC flag

There has been a recent change to the new powervr KMD to always zero buffer
objects at allocation time to avoid information leaks. This change was made to
address upstream feedback [1]. The result is that the
PVR_WINSYS_BO_FLAG_ZERO_ON_ALLOC no longer makes a difference when using this
KMD.

As the powervr KMD is the one we actually care about, it makes sense to mirror
this change when using the downstream pvrsrvkm KMD in order to avoid differences
in behaviour between the two KMDs. As this makes the
PVR_WINSYS_BO_FLAG_ZERO_ON_ALLOC flag entirely redundant, remove it.

[1] https://lists.freedesktop.org/archives/dri-devel/2023-August/418042.html

Signed-off-by: Vlad Schiller <vlad-radu.schiller@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24930>
src/imagination/common/pvr_debug.c
src/imagination/common/pvr_debug.h
src/imagination/vulkan/pvr_bo.c
src/imagination/vulkan/pvr_bo.h
src/imagination/vulkan/pvr_job_render.c
src/imagination/vulkan/winsys/pvr_winsys.h
src/imagination/vulkan/winsys/pvrsrvkm/pvr_srv_bo.c