dlm: free workqueues after the connections
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Sat, 8 Oct 2016 13:14:37 +0000 (10:14 -0300)
committerDavid Teigland <teigland@redhat.com>
Mon, 10 Oct 2016 14:54:00 +0000 (09:54 -0500)
commit3a8db79889ce16930aff19b818f5b09651bb7644
treee4395e493ec475bbcb9402e647e9429b56be3db3
parentc8d2bc9bc39ebea8437fd974fdbc21847bb897a3
dlm: free workqueues after the connections

After backporting commit ee44b4bc054a ("dlm: use sctp 1-to-1 API")
series to a kernel with an older workqueue which didn't use RCU yet, it
was noticed that we are freeing the workqueues in dlm_lowcomms_stop()
too early as free_conn() will try to access that memory for canceling
the queued works if any.

This issue was introduced by commit 0d737a8cfd83 as before it such
attempt to cancel the queued works wasn't performed, so the issue was
not present.

This patch fixes it by simply inverting the free order.

Cc: stable@vger.kernel.org
Fixes: 0d737a8cfd83 ("dlm: fix race while closing connections")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/lowcomms.c