xfrm: fix "disable_policy" on ipv4 early demux
authorEyal Birger <eyal.birger@gmail.com>
Sun, 9 Oct 2022 19:16:43 +0000 (22:16 +0300)
committerSteffen Klassert <steffen.klassert@secunet.com>
Wed, 12 Oct 2022 08:45:34 +0000 (10:45 +0200)
commit3a5913183aa1b14148c723bda030e6102ad73008
treef51bc6d6169112c93f8148f86440879c3c90a821
parent1d22f78d05737ce21bff7b88b6e58873f35e65ba
xfrm: fix "disable_policy" on ipv4 early demux

The commit in the "Fixes" tag tried to avoid a case where policy check
is ignored due to dst caching in next hops.

However, when the traffic is locally consumed, the dst may be cached
in a local TCP or UDP socket as part of early demux. In this case the
"disable_policy" flag is not checked as ip_route_input_noref() was only
called before caching, and thus, packets after the initial packet in a
flow will be dropped if not matching policies.

Fix by checking the "disable_policy" flag also when a valid dst is
already available.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216557
Reported-by: Monil Patel <monil191989@gmail.com>
Fixes: e6175a2ed1f1 ("xfrm: fix "disable_policy" flag use when arriving from different devices")
Signed-off-by: Eyal Birger <eyal.birger@gmail.com>
----

v2: use dev instead of skb->dev
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/ipv4/ip_input.c