Revert "core: set PROVIDER type as Persistent class id"
authorBen Noordhuis <info@bnoordhuis.nl>
Thu, 28 May 2015 19:11:12 +0000 (21:11 +0200)
committerBen Noordhuis <info@bnoordhuis.nl>
Thu, 28 May 2015 19:48:44 +0000 (21:48 +0200)
commit3a1bc067d467c54853747e1697c7c1bcc010aae1
tree7acfb59e000df4581c73974ceaffb05887d2dbc9
parenta77c330c32fc1c2ffd5069e3ca57e4d3478b2e5e
Revert "core: set PROVIDER type as Persistent class id"

This reverts commit 3c44100558b4e9e48e0e711e38acc91e0f870a9f.

Reverted for breaking node-heapdump[0].

AsyncWrap assigns a class id but does not set a v8::RetainedObjectInfo
provider callback with v8::HeapProfiler::SetWrapperClassInfoProvider().
The result is a null pointer dereference when taking a heap snapshot.

It can probably be solved by setting a generic provider callback inside
the AsyncWrap constructor but that may have performance ramifications
that need to be investigated first.  I move to revert it for now.

[0] https://github.com/bnoordhuis/node-heapdump

PR-URL: https://github.com/nodejs/io.js/pull/1827
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
src/async-wrap-inl.h
src/base-object-inl.h
src/base-object.h