alx: fix OOB-read compiler warning
authorGONG, Ruiqi <gongruiqi1@huawei.com>
Mon, 21 Aug 2023 01:32:18 +0000 (09:32 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 22 Aug 2023 10:30:15 +0000 (12:30 +0200)
commit3a198c95c95da10ad844cbeade2fe40bdf14c411
tree7bbba25268a9059ccd569310cfdc214b492834b5
parent90308679c297ffcbb317c715ef434e9fb3c881dc
alx: fix OOB-read compiler warning

The following message shows up when compiling with W=1:

In function ‘fortify_memcpy_chk’,
    inlined from ‘alx_get_ethtool_stats’ at drivers/net/ethernet/atheros/alx/ethtool.c:297:2:
./include/linux/fortify-string.h:592:4: error: call to ‘__read_overflow2_field’
declared with attribute warning: detected read beyond size of field (2nd parameter);
maybe use struct_group()? [-Werror=attribute-warning]
  592 |    __read_overflow2_field(q_size_field, size);
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

In order to get alx stats altogether, alx_get_ethtool_stats() reads
beyond hw->stats.rx_ok. Fix this warning by directly copying hw->stats,
and refactor the unnecessarily complicated BUILD_BUG_ON btw.

Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20230821013218.1614265-1-gongruiqi@huaweicloud.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/atheros/alx/ethtool.c