[AArch64][SVE] NFCI: Choose consistent naming for predicated SDAG nodes
authorSander de Smalen <sander.desmalen@arm.com>
Mon, 29 Jun 2020 10:41:22 +0000 (11:41 +0100)
committerSander de Smalen <sander.desmalen@arm.com>
Mon, 29 Jun 2020 12:37:30 +0000 (13:37 +0100)
commit39f6a36a24ce8b047f21d69ec1277e12ce6236d0
tree95158f75a7d0325cf06b931b57d5e85346b0139d
parent4822291da5b3a2db3b83d80a0876b26f7d6dd00a
[AArch64][SVE] NFCI: Choose consistent naming for predicated SDAG nodes

This patch proposes a naming convention for operations that take
a general predicate (and are thus predicated) that specifies
what happens to the false lanes.

Currently the _PRED suffix is used, which doesn't really say much other
than that it takes a predicate. In some instances this means it has
merging predication and in other cases it means zeroing-predication.

This patch also changes the order of operands to
AArch64ISD::DUP_MERGE_PASSTHRU, to pass the predicate as the first
operand, which is in line with all other predicates nodes. It takes the
passthru value as an explicit passthru value, which is always passed as
the last operand.

Reviewers: paulwalker-arm, cameron.mcinally, eli.friedman, dancgr, efriedma

Reviewed By: paulwalker-arm

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D81850
llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
llvm/lib/Target/AArch64/AArch64ISelLowering.h
llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
llvm/lib/Target/AArch64/SVEInstrFormats.td