Address post commit review comments on revision 366727.
authorSean Fertile <sfertile@ca.ibm.com>
Tue, 30 Jul 2019 15:37:01 +0000 (15:37 +0000)
committerSean Fertile <sfertile@ca.ibm.com>
Tue, 30 Jul 2019 15:37:01 +0000 (15:37 +0000)
commit39f35038140d2e21023eefcc7acc65c5b68fc77f
treea802eef10fcbd462c2dcc26f4534f988c600898b
parent027bb52790ed825788806799f6b7391e2f17c2c1
Address post commit review comments on revision 366727.

Addresses number of comment made on D64652 after commiting:

- Reorders function decls in the TargetLoweringObjectFileXCOFF class.
- Fix comment in MCSectionXCOFF to include description of external reference
  csects.
- Convert several llvm_unreachables to report_fatal_error
- Convert several dyn_casts to casts as they are expected not to fail.
- Avoid copying DataLayout object.

llvm-svn: 367324
llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h
llvm/include/llvm/MC/MCSectionXCOFF.h
llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
llvm/lib/MC/MCSectionXCOFF.cpp
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
llvm/test/CodeGen/PowerPC/aix-xcoff-common.ll