USB: cdc-acm: fix write and resume race
authorJohan Hovold <jhovold@gmail.com>
Mon, 26 May 2014 17:23:37 +0000 (19:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Jun 2014 19:15:41 +0000 (15:15 -0400)
commit39d43e4ede7dbb4001a025e157688139c1e2dbdb
tree9cb91481453ab8b082ec868016b108ab8ad38944
parent2d0227bd3d32c96be8c14fd860b0de9fbc87b155
USB: cdc-acm: fix write and resume race

commit e144ed28bed10684f9aaec6325ed974d53f76110 upstream.

Fix race between write() and resume() due to improper locking that could
lead to writes being reordered.

Resume must be done atomically and susp_count be protected by the
write_lock in order to prevent racing with write(). This could otherwise
lead to writes being reordered if write() grabs the write_lock after
susp_count is decremented, but before the delayed urb is submitted.

Fixes: 11ea859d64b6 ("USB: additional power savings for cdc-acm devices
that support remote wakeup")

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/cdc-acm.c