qcow2: fix new_blocks double-free in alloc_refcount_block()
authorStefan Hajnoczi <stefanha@redhat.com>
Fri, 15 Aug 2014 16:59:54 +0000 (17:59 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 15 Aug 2014 17:03:26 +0000 (18:03 +0100)
commit39ba3bf69c4ef4d8a8b683ee7282efd25b3f01ff
tree8b84be5bb2e566c9778f9492410c75e31b57d596
parent94c83a24c1956cd50ab979725a730f7d8649ac15
qcow2: fix new_blocks double-free in alloc_refcount_block()

Commit de82815db1c89da058b7fb941dab137d6d9ab738 ("qcow2: Handle failure
for potentially large allocations") introduced a double-free of
new_blocks in the alloc_refcount_block() error path.

The qemu-iotests qcow2 026 test case was failing because qemu-io
segfaulted.

Make sure new_blocks is NULL after we free it the first time.

Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/qcow2-refcount.c