net/mlx5e: Verify that rule has at least one fwd/drop action
authorVlad Buslov <vladbu@mellanox.com>
Wed, 11 Sep 2019 18:14:54 +0000 (21:14 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Dec 2019 15:44:32 +0000 (16:44 +0100)
commit39a1c83595cb38cdc326fe0eeb3f218264ffcb99
tree9598f8051d50cbb93abd0cc7d511cfcf5a826ece
parent1fca505614091c9a0b95968cd7f8485732f53bfc
net/mlx5e: Verify that rule has at least one fwd/drop action

[ Upstream commit ae2741e2b6ce2bf1b656b1152c4ef147ff35b096 ]

Currently, mlx5 tc layer doesn't verify that rule has at least one forward
or drop action which leads to following firmware syndrome when user tries
to offload such action:

[ 1824.860501] mlx5_core 0000:81:00.0: mlx5_cmd_check:753:(pid 29458): SET_FLOW_TABLE_ENTRY(0x936) op_mod(0x0) failed, status bad parameter(0x3), syndrome (0x144b7a)

Add check at the end of parse_tc_fdb_actions() that verifies that resulting
attribute has action fwd or drop flag set.

Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Reviewed-by: Paul Blakey <paulb@mellanox.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c