drm/i915: Include register polling in reg_rw traces
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 4 Feb 2019 21:16:44 +0000 (23:16 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 5 Feb 2019 18:44:43 +0000 (20:44 +0200)
commit39806c3f11e206d03e76521c808a96aedfcc58d9
tree1faa0fefb947c5f2eeae8601e802338d3fe73fed
parentab1ab0eb0cb64d1c225bdf42bee067f81c87e2a4
drm/i915: Include register polling in reg_rw traces

We generally omit register polling from the i915_reg_rw tracepoint.
Understandable since polling could generate a lot of noise in the
trace. The downside is that the trace is incomplete. As a compromise
let's trace the final register value observed while polling. That
should be generally sufficient to observe what the code should be
doing next.

I suppose in some cases it might make sense to also trace the initial
register value, and maybe the number of times we polled. But that
would require a separate tracepoint so let's leave it for the future.

The other users of _NOTRACE() are i915_pmu and i2c bitbanging,
which I decided to leave alone.

Next we should do something to claw back the tracepoints for
planes and whatnot which were switched to _FW() a while back.
I guess just new macros for raw_rw+trace. The question is
what to call it?

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190204211644.21967-1-ville.syrjala@linux.intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/i915_drv.c
drivers/gpu/drm/i915/intel_dp.c
drivers/gpu/drm/i915/intel_uncore.c