fw_base: Put data in .data rather than .text
authorJessica Clarke <jrtc27@jrtc27.com>
Sun, 11 Jul 2021 02:28:20 +0000 (03:28 +0100)
committerAnup Patel <anup@brainfault.org>
Sun, 11 Jul 2021 12:03:30 +0000 (17:33 +0530)
commit397afe5ba1e9abeb48b801c864a56bda415441ce
tree66ca4e756d8ae51e28c710d644b410582b1f3b21
parent7f1be8a624aca4805020588894d96c3617860c89
fw_base: Put data in .data rather than .text

The -N linker option is supposed to make .text writable, but GNU ld and
LLD differ in interpreting what that means. GNU ld will happily let you
have relocations in it, but LLD will see that the input section is
read-only (even though the output section is writable) and give an
error. It's unclear if either of them intend to have that behaviour in
this edge case, but regardless there's no reason not to just put the
data in a writable .data section.

Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Anup Patel <anup.patel@wdc.com>
firmware/fw_base.S