pan/bi: Don't allow ATEST to take a temporary
authorAlyssa Rosenzweig <alyssa@collabora.com>
Fri, 19 Aug 2022 22:30:01 +0000 (18:30 -0400)
committerMarge Bot <emma+marge@anholt.net>
Sun, 21 Aug 2022 19:37:10 +0000 (19:37 +0000)
commit394e1f5862a5cd537f60c01ed75dc698e112da58
tree41059bc535c82ae1d91d4895541a0c6a5a3cf5b5
parente12a9ce8d691a311cd37eecbdeadb30400adeb95
pan/bi: Don't allow ATEST to take a temporary

Clause scheduler edition of db2bdc1dc37 ("pan/bi: Require ATEST coverage mask
input in R60"). ATEST wants to read r60, which can't work if its input isn't
even in a register.

When per-sample shading isn't in use, prevents regressions in:

   KHR-GLES31.core.sample_variables.mask.*

These tests previously passed because per-sample shading was forced. It's
not clear whether the bug addressed in this patch is possible to hit "in the
wild", i.e. without the optimizations in this series that allow us to use
per-pixel shading in more cases.

No shader-db changes.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17841>
src/panfrost/bifrost/bi_schedule.c