fsverity: explicitly check for buffer overflow in build_merkle_tree()
authorEric Biggers <ebiggers@google.com>
Tue, 28 Mar 2023 04:15:05 +0000 (21:15 -0700)
committerEric Biggers <ebiggers@google.com>
Wed, 12 Apr 2023 02:23:23 +0000 (19:23 -0700)
commit39049b69ec9fc125fa1f314165dcc86f72cb72ec
treef7551132981d66deaf709634edee1fd69c4c3147
parent8eb8af4b3df5965dc65a24a32768043f39d82d59
fsverity: explicitly check for buffer overflow in build_merkle_tree()

The new Merkle tree construction algorithm is a bit fragile in that it
may overflow the 'root_hash' array if the tree actually generated does
not match the calculated tree parameters.

This should never happen unless there is a filesystem bug that allows
the file size to change despite deny_write_access(), or a bug in the
Merkle tree logic itself.  Regardless, it's fairly easy to check for
buffer overflow here, so let's do so.

This is a robustness improvement only; this case is not currently known
to be reachable.  I've added a Fixes tag anyway, since I recommend that
this be included in kernels that have the mentioned commit.

Fixes: 56124d6c87fd ("fsverity: support enabling with tree block size < PAGE_SIZE")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20230328041505.110162-1-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
fs/verity/enable.c