cpufreq: s5pv210: add missing of_node_put()
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 21 Jul 2017 19:53:30 +0000 (21:53 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 26 Jul 2017 20:54:01 +0000 (22:54 +0200)
commit38c1c6a9f3c4c919c82cc20d4c70814c64574887
tree7d48cd2ccf8d16b78db61119b979e27ef4e38a56
parentfc4c709fc88d5603b235ba18d11f6dba811e1664
cpufreq: s5pv210: add missing of_node_put()

for_each_compatible_node performs an of_node_get on each iteration, so a
return from the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e,e1,e2;
statement S;
iterator i1;
iterator name for_each_compatible_node;
@@

 for_each_compatible_node(n,e1,e2) {
   ...
(
   of_node_put(n);
|
   e = n
|
   return n;
|
   i1(...,n,...) S
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Additionally, call of_node_put on the previous value of np, obtained from
of_find_compatible_node, that is no longer accessible at the point of the
for_each_compatible_node.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/s5pv210-cpufreq.c