rpmsg: qcom_smd: Convert to platform remove callback returning void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 21 Mar 2023 15:40:39 +0000 (16:40 +0100)
committerBjorn Andersson <andersson@kernel.org>
Thu, 6 Apr 2023 03:58:32 +0000 (20:58 -0700)
commit38be89514b88f53ff772d1e016a68b59814aef72
treedcc3145a759953827af3591c4dde19f5ac794f8f
parent49446e573bf591eef71c1e8c7cf87ec19aa2569f
rpmsg: qcom_smd: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

qcom_smd_remove() always returned zero, though that isn't completely
trivial to see. So explain that in a comment and convert to
.remove_new().

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230321154039.355098-4-u.kleine-koenig@pengutronix.de
drivers/rpmsg/qcom_smd.c