crypto: qce - fix uaf on qce_skcipher_register_one
authorChengfeng Ye <cyeaa@connect.ust.hk>
Thu, 4 Nov 2021 13:46:42 +0000 (06:46 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:03:14 +0000 (11:03 +0100)
commit38a721f609267788bbdbcc8bee3299f3ec8b4428
treea35dac8addc51b4f0b5fa4570a38528a1994896a
parent561030c55120893b4d8c939c7891907144fb0bee
crypto: qce - fix uaf on qce_skcipher_register_one

[ Upstream commit e9c195aaeed1b45c9012adbe29dedb6031e85aa8 ]

Pointer alg points to sub field of tmpl, it
is dereferenced after tmpl is freed. Fix
this by accessing alg before free tmpl.

Fixes: ec8f5d8f ("crypto: qce - Qualcomm crypto engine driver")
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/qce/skcipher.c