net: phy: use boolean dt properties for eee broken modes
authorjbrunet <jbrunet@baylibre.com>
Mon, 19 Dec 2016 15:05:37 +0000 (16:05 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jul 2017 12:40:19 +0000 (14:40 +0200)
commit3897ae12b706bfc47c07a1eef58fe6ce328784cf
treed3055228af7ef0ebc8b86571ef40b854ad0eead9
parent40373d91a0f764c8ba5c56ea3dc88896faa4510d
net: phy: use boolean dt properties for eee broken modes

[ Upstream commit 57f3986231bb2c69a55ccab1d2b30a00818027ac ]

The patches regarding eee-broken-modes was merged before all people
involved could find an agreement on the best way to move forward.

While we agreed on having a DT property to mark particular modes as broken,
the value used for eee-broken-modes mapped the phy register in very direct
way. Because of this, the concern is that it could be used to implement
configuration policies instead of describing a broken HW.

In the end, having a boolean property for each mode seems to be preferred
over one bit field value mapping the register (too) directly.

Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/phy/phy_device.c