[analyzer] PR41239: Fix a crash on invalid source location in NoStoreFuncVisitor.
authorArtem Dergachev <artem.dergachev@gmail.com>
Fri, 29 Mar 2019 22:57:49 +0000 (22:57 +0000)
committerArtem Dergachev <artem.dergachev@gmail.com>
Fri, 29 Mar 2019 22:57:49 +0000 (22:57 +0000)
commit388e19ff1f10aa251fdae4cdfd729944c440eac4
tree3f594c1b6b0719981d7521dce0686d20079efb93
parente3a845e25ecc541f37dac31c7f2d6c5e7eb5c310
[analyzer] PR41239: Fix a crash on invalid source location in NoStoreFuncVisitor.

It turns out that SourceManager::isInSystemHeader() crashes when an invalid
source location is passed into it. Invalid source locations are relatively
common: not only they come from body farms, but also, say, any function in C
that didn't come with a forward declaration would have an implicit
forward declaration with invalid source locations.

There's a more comfy API for us to use in the Static Analyzer:
CallEvent::isInSystemHeader(), so just use that.

Differential Revision: https://reviews.llvm.org/D59901

llvm-svn: 357329
clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
clang/test/Analysis/diagnostics/no-store-func-path-notes.c