Try enabling -Wsuggest-override again, using add_compile_options instead of add_compi...
authorLogan Smith <logan.r.smith0@gmail.com>
Wed, 22 Jul 2020 21:16:35 +0000 (14:16 -0700)
committerLogan Smith <logan.r.smith0@gmail.com>
Wed, 22 Jul 2020 21:19:34 +0000 (14:19 -0700)
commit388c9fb1af48b059d8b65cb2e002e0992d147aa5
tree1f2af2e867b41fbb248508829aac348f1d633260
parent5c2451785dfe6d8a4448690cd1f1c247036bfca6
Try enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories.

Using add_compile_definitions caused the flag to be passed to rc.exe on Windows and thus broke Windows builds.
18 files changed:
clang-tools-extra/clangd/unittests/CMakeLists.txt
clang-tools-extra/unittests/CMakeLists.txt
clang/unittests/CMakeLists.txt
compiler-rt/cmake/Modules/AddCompilerRT.cmake
compiler-rt/cmake/config-ix.cmake
flang/unittests/CMakeLists.txt
libcxx/CMakeLists.txt
libcxxabi/CMakeLists.txt
lld/unittests/CMakeLists.txt
lldb/unittests/CMakeLists.txt
llvm/cmake/modules/HandleLLVMOptions.cmake
llvm/lib/Testing/Support/CMakeLists.txt
llvm/unittests/CMakeLists.txt
llvm/utils/benchmark/CMakeLists.txt
llvm/utils/unittest/CMakeLists.txt
mlir/unittests/CMakeLists.txt
parallel-libs/acxxel/CMakeLists.txt
polly/unittests/CMakeLists.txt