x86/kaslr: Drop test for command-line parameters before parsing
authorArvind Sankar <nivedita@alum.mit.edu>
Tue, 28 Jul 2020 22:57:14 +0000 (18:57 -0400)
committerIngo Molnar <mingo@kernel.org>
Fri, 31 Jul 2020 09:08:17 +0000 (11:08 +0200)
commit3870d971791f13df88a7a656e3fd6e2df8686097
tree6140d277cf8df222d2f45f41bceb957e0ac797e9
parentbe9e8d9541a95bdfac1c13d112cc032ea7fc745f
x86/kaslr: Drop test for command-line parameters before parsing

This check doesn't save anything. In the case when none of the
parameters are present, each strstr will scan args twice (once to find
the length and then for searching), six scans in total. Just going ahead
and parsing the arguments only requires three scans: strlen, memcpy, and
parsing. This will be the first malloc, so free will actually free up
the memory, so the check doesn't save heap space either.

Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20200728225722.67457-14-nivedita@alum.mit.edu
arch/x86/boot/compressed/kaslr.c