silicom: remaining checkpatch issues in bypass.c
authorMichael Hoefler <michael.hoefler@studium.uni-erlangen.de>
Fri, 20 Dec 2013 13:51:13 +0000 (14:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Dec 2013 17:04:49 +0000 (09:04 -0800)
commit382d277b38785aafd0705488bf895cf85abef93a
treed12e5ab1297ae8e8c0e3e445115e7050db620e1f
parent6618b7506962ccc2ee78965af9083e836d0dd371
silicom: remaining checkpatch issues in bypass.c

In this patch we fix some "logical" errors in bypass.c of the silicom bypass
driver (in staging).

Checkpatch complains about the following errors:
 - unnecessary forward declarations in a source file
 - assignment in if condition

In addition to that the __init and __exit macros were missing at the init and
cleanup function.

There are still two warnings left for this file related to too many leadingtabs
at nested blocks. I did not touch this issue becasue the code needs really some
refactoring. And since i do not have the appropriate hardware to test the code,
i do not change the functionality in any way.

Signed-off-by: Michael Hoefler <michael.hoefler@studium.uni-erlangen.de>
Signed-off-by: Christoph Kohl <christoph.kohl@t-online.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/silicom/bypasslib/bypass.c