Add nullable annotations for XmlDataDocument (#41541)
authorImmo Landwerth <immol@microsoft.com>
Tue, 1 Sep 2020 01:09:41 +0000 (18:09 -0700)
committerGitHub <noreply@github.com>
Tue, 1 Sep 2020 01:09:41 +0000 (18:09 -0700)
commit381c16487e87afbf929a7de60ea8006820ac32eb
tree369a938dfb0f5f34cf544cc7bdc38de7e8b35fd4
parent4d784693ebc5f91c7eede32170046355ef3969b2
Add nullable annotations for XmlDataDocument (#41541)

* Add nullable annotations for XmlDataDocument

* Address code review feedback

* More code review feedback

* Address Eric's feedback

* Annotate _dataSet as not null when AttachDataSet is called

* Fix GetElementById return type annotation

In order to match with src

Co-authored-by: Jeff Handley <jeff.handley@microsoft.com>
Co-authored-by: David CantĂș <dacantu@microsoft.com>
12 files changed:
src/libraries/System.Data.Common/ref/System.Data.Common.cs
src/libraries/System.Data.Common/src/System/Xml/BaseTreeIterator.cs
src/libraries/System.Data.Common/src/System/Xml/DataDocumentXPathNavigator.cs
src/libraries/System.Data.Common/src/System/Xml/DataPointer.cs
src/libraries/System.Data.Common/src/System/Xml/DataSetMappper.cs
src/libraries/System.Data.Common/src/System/Xml/IXmlDataVirtualNode.cs
src/libraries/System.Data.Common/src/System/Xml/RegionIterator.cs
src/libraries/System.Data.Common/src/System/Xml/TreeIterator.cs
src/libraries/System.Data.Common/src/System/Xml/XPathNodePointer.cs
src/libraries/System.Data.Common/src/System/Xml/XmlBoundElement.cs
src/libraries/System.Data.Common/src/System/Xml/XmlDataDocument.cs
src/libraries/System.Data.Common/src/System/Xml/XmlDataImplementation.cs