platform/x86: intel_pmc_core: Uninitialized data in pmc_core_lpm_latch_mode_write()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 21 Apr 2021 15:19:27 +0000 (18:19 +0300)
committerHans de Goede <hdegoede@redhat.com>
Wed, 21 Apr 2021 19:32:31 +0000 (21:32 +0200)
commit37bd59d3cef8e90055dc26e25d9aba00f06f5f9f
treee57cfe7e34acf290e638b4657ef40f48a147efb5
parentf75bf693c919438cbe44717d63aa11856a062b9a
platform/x86: intel_pmc_core: Uninitialized data in pmc_core_lpm_latch_mode_write()

The simple_write_to_buffer() can return success if even a single byte
is copied from user space.  In this case it can result in using
uninitalized data if the buf[] array is not fully initialized.  Really
we should only succeed if the whole buffer is copied.

Just using copy_from_user() is simpler and more appropriate.

Fixes: 8074a79fad2e ("platform/x86: intel_pmc_core: Add option to set/clear LPM mode")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YIBCf+G9Ef8wrGJw@mwanda
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/intel_pmc_core.c