Input: applespi - use struct_size() helper
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 6 Aug 2019 16:03:16 +0000 (09:03 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 6 Aug 2019 16:10:56 +0000 (09:10 -0700)
commit37ad2e343449ced9e41505eae5494bf40f433181
treea86ee9d347d08cbec0b61978fb2ee278bb150c79
parentc88090dfc84254fa149174eb3e6a8458de1912c4
Input: applespi - use struct_size() helper

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct touchpad_protocol {
...
        struct tp_finger        fingers[0];
};

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

So, replace the following form:

sizeof(*tp) + tp->number_of_fingers * sizeof(tp->fingers[0]);

with:

struct_size(tp, fingers, tp->number_of_fingers)

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/applespi.c