video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow
authorTim Gardner <tim.gardner@canonical.com>
Mon, 27 Sep 2021 15:45:02 +0000 (09:45 -0600)
committerHelge Deller <deller@gmx.de>
Sat, 29 Jan 2022 21:24:25 +0000 (22:24 +0100)
commit37a1a2e6eeeb101285cd34e12e48a881524701aa
tree0f05978f72370bdd2eaf032311c02338daf6f600
parent1e3c3e6193d45afd5879da5a82b2c92997b0ebe9
video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

Coverity complains of a possible buffer overflow. However,
given the 'static' scope of nvidia_setup_i2c_bus() it looks
like that can't happen after examiniing the call sites.

CID 19036 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW)
1. fixed_size_dest: You might overrun the 48-character fixed-size string
  chan->adapter.name by copying name without checking the length.
2. parameter_as_source: Note: This defect has an elevated risk because the
  source argument is a parameter of the current function.
 89        strcpy(chan->adapter.name, name);

Fix this warning by using strscpy() which will silence the warning and
prevent any future buffer overflows should the names used to identify the
channel become much longer.

Cc: Antonino Daplas <adaplas@gmail.com>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/nvidia/nv_i2c.c