Revert "D11003: Tolerate DWARF compile unit without filename."
authorPavel Labath <pavel@labath.sk>
Wed, 29 May 2019 11:28:35 +0000 (11:28 +0000)
committerPavel Labath <pavel@labath.sk>
Wed, 29 May 2019 11:28:35 +0000 (11:28 +0000)
commit377c1cfe9495810f8416c626103708340e2a0038
tree390293819220d0251c3a1ffe5e90446674a04418
parent72e05d0aa4ff192c75e5e0137aec377ae5cd2a9b
Revert "D11003: Tolerate DWARF compile unit without filename."

Summary:
This code is modifying a support file list after it has been created.
This makes it hard to share the file list between type units and
compile units in DWARF. It's not a total showstopper, but supporting
this while also sharing the lists would make things more complicated.

Given that this was added to support a project which never fully
materialised, and that even back then there were some concerns about the
correctness of this approach (according to D11003#200772 the compile
unit name is not guaranteed to be the first one in the support file
list), I think we should just delete this workaround.

Reviewers: clayborg, tberghammer, dsrbecky

Subscribers: aprantl, lldb-commits

Differential Revision: https://reviews.llvm.org/D62517

llvm-svn: 361948
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp