Target: correct the return value for `GetImageAddrFromToken`
authorSaleem Abdulrasool <compnerd@compnerd.org>
Tue, 7 Apr 2020 00:33:38 +0000 (17:33 -0700)
committerSaleem Abdulrasool <compnerd@compnerd.org>
Tue, 7 Apr 2020 00:37:57 +0000 (17:37 -0700)
commit3775be2d8e17aaeae62ab83ded005867f4bf70ac
tree1b61f60b280834f87cf230e4163f6a8dfac780b3
parent469580a9677473f4ee19d80861f7a5da4e0f316d
Target: correct the return value for `GetImageAddrFromToken`

We would return `LLDB_INVALID_IMAGE_TOKEN` for the address rather than
the correct value of `LLDB_IMAGE_ADDRESS`.  This would result in the
check for the return value to silently pass on x64 as the invalid
address and invalid token are of different sizes (`size_t` vs
`uintprr_t`).  This corrects the return value to `LLDB_INVALID_ADDRESS`
and addresses the rest to reset the mapped address to the invalid value.

This was found by inspection when trying to implement module support for
Windows.
lldb/source/Target/Process.cpp