kunit: Assign strings to 'const char*' in STREQ assertions
authorDavid Gow <davidgow@google.com>
Thu, 13 May 2021 19:31:56 +0000 (12:31 -0700)
committerShuah Khan <skhan@linuxfoundation.org>
Wed, 23 Jun 2021 22:35:25 +0000 (16:35 -0600)
commit3747b5c0d8ec8b03b0856e29241949baa0e67803
treec8cfee4a7f43f3a5a45d10aa1820fb7a29cc20b7
parent6e62dfa6d14f8fd2b07ad30b8a1c597d40d36ac1
kunit: Assign strings to 'const char*' in STREQ assertions

Currently, the KUNIT_EXPECT_STREQ() and related macros assign both
string arguments to variables of their own type (via typeof()). This
seems to be to prevent the macro argument from being evaluated multiple
times.

However, this doesn't work if one of these is a fixed-length character
array, rather than a character pointer, as (for example) char[16] will
always allocate a new string.

By always using 'const char*' (the type strcmp expects), we're always
just taking a pointer to the string, which works even with character
arrays.

Signed-off-by: David Gow <davidgow@google.com>
Reviewed-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
include/kunit/test.h