KVM: s390: make if statements in lpsw/lpswe handlers readable
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Mon, 25 Mar 2013 16:22:52 +0000 (17:22 +0100)
committerGleb Natapov <gleb@redhat.com>
Tue, 2 Apr 2013 13:14:36 +0000 (16:14 +0300)
commit3736b874a39a1df2a94186c357aabeb6a7d7d4f6
treed1f52792219577767ca33a4c0aa0211ef6e836da
parent6fd0fcc93b1eaf82911782de5c7aa35c174bf620
KVM: s390: make if statements in lpsw/lpswe handlers readable

Being unable to parse the 5- and 8-line if statements I had to split them
to be able to make any sense of them and verify that they match the
architecture.
So change the code since I guess that other people will also have a hard
time parsing such long conditional statements with line breaks.

Introduce a common is_valid_psw() function which does all the checks needed.
In case of lpsw (64 bit psw -> 128 bit psw conversion) it will do some not
needed additional checks, since a couple of bits can't be set anyway, but
that doesn't hurt.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Gleb Natapov <gleb@redhat.com>
arch/s390/kvm/priv.c