net: mptcp: make DACK4/DACK8 usage consistent among all subflows
authorDavide Caratti <dcaratti@redhat.com>
Tue, 6 Oct 2020 16:26:17 +0000 (18:26 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 9 Oct 2020 15:25:48 +0000 (08:25 -0700)
commit37198e93ced70733f0b993dff28b7c33857e254f
tree5efe9e0415abf424ed26afd3563052862864ebe4
parent0da1ccbbefb662915228bc17e1c7d4ad28b3ddab
net: mptcp: make DACK4/DACK8 usage consistent among all subflows

using packetdrill it's possible to observe the same MPTCP DSN being acked
by different subflows with DACK4 and DACK8. This is in contrast with what
specified in RFC8684 ยง3.3.2: if an MPTCP endpoint transmits a 64-bit wide
DSN, it MUST be acknowledged with a 64-bit wide DACK. Fix 'use_64bit_ack'
variable to make it a property of MPTCP sockets, not TCP subflows.

Fixes: a0c1d0eafd1e ("mptcp: Use 32-bit DATA_ACK when possible")
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/options.c
net/mptcp/protocol.h
net/mptcp/subflow.c