clk: ti: composite: Prefer kcalloc over open coded arithmetic
authorLen Baker <len.baker@gmx.com>
Sat, 4 Sep 2021 13:17:14 +0000 (15:17 +0200)
committerStephen Boyd <sboyd@kernel.org>
Sat, 21 May 2022 03:40:07 +0000 (20:40 -0700)
commit37004db2a560d7f0641bc81f0d405b8b9849e797
tree2ab788b386bafc7f2825dd24257f8081333a62bd
parentbae71de51b8901372d7ed5c6b89d32282db7e9ed
clk: ti: composite: Prefer kcalloc over open coded arithmetic

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
size * count in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
Link: https://lore.kernel.org/r/20210904131714.2312-1-len.baker@gmx.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/ti/composite.c