xen: detect uninitialized xenbus in xenbus_init
authorStefano Stabellini <stefano.stabellini@xilinx.com>
Tue, 23 Nov 2021 21:07:48 +0000 (13:07 -0800)
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>
Wed, 24 Nov 2021 14:55:15 +0000 (08:55 -0600)
commit36e8f60f0867d3b70d398d653c17108459a04efe
tree6ef063e1bd5cc7c7340a5a207081525243766e6e
parentde6da33e6cb79abd4a5721b65b9a7dbed24378f8
xen: detect uninitialized xenbus in xenbus_init

If the xenstore page hasn't been allocated properly, reading the value
of the related hvm_param (HVM_PARAM_STORE_PFN) won't actually return
error. Instead, it will succeed and return zero. Instead of attempting
to xen_remap a bad guest physical address, detect this condition and
return early.

Note that although a guest physical address of zero for
HVM_PARAM_STORE_PFN is theoretically possible, it is not a good choice
and zero has never been validly used in that capacity.

Also recognize all bits set as an invalid value.

For 32-bit Linux, any pfn above ULONG_MAX would get truncated. Pfns
above ULONG_MAX should never be passed by the Xen tools to HVM guests
anyway, so check for this condition and return early.

Cc: stable@vger.kernel.org
Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Link: https://lore.kernel.org/r/20211123210748.1910236-1-sstabellini@kernel.org
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
drivers/xen/xenbus/xenbus_probe.c