c++: explicit specialization and trailing requirements [PR107864]
authorPatrick Palka <ppalka@redhat.com>
Tue, 29 Nov 2022 14:55:21 +0000 (09:55 -0500)
committerPatrick Palka <ppalka@redhat.com>
Tue, 29 Nov 2022 14:55:21 +0000 (09:55 -0500)
commit36cabc257dfb7dd4f7625896891f6c5b195a0241
treec59bd6d2f0e207a37c6cc857cd34af0e01b9c9a2
parentfd8dd6c0384969170e594be34da278a072d5eb76
c++: explicit specialization and trailing requirements [PR107864]

Here we're crashing when using the explicit specialization of the
function template g with trailing requirements ultimately because
earlier decls_match (called indirectly from register_specialization) for
for the explicit specialization returned false since the template has
trailing requirements whereas the specialization doesn't.

In r12-2230-gddd25bd1a7c8f4, we fixed a similar issue concerning template
requirements instead of trailing requirements.  We could extend that fix
to ignore trailing requirement mismatches for explicit specializations
as well, but it seems cleaner to just propagate constraints from the
specialized template to the specialization when declaring an explicit
specialization so that decls_match will naturally return true in this
case.  And it looks like determine_specialization already does this,
albeit inconsistently (only when specializing a non-template member
function of a class template as in cpp2a/concepts-explicit-spec4.C).

So this patch makes determine_specialization consistently propagate
constraints from the specialized template to the specialization, which
in turn lets us get rid of the function_requirements_equivalent_p special
case added by r12-2230.

PR c++/107864

gcc/cp/ChangeLog:

* decl.cc (function_requirements_equivalent_p): Don't check
DECL_TEMPLATE_SPECIALIZATION.
* pt.cc (determine_specialization): Propagate constraints when
specializing a function template too.  Simplify by using
add_outermost_template_args.

gcc/testsuite/ChangeLog:

* g++.dg/concepts/explicit-spec1a.C: New test.
gcc/cp/decl.cc
gcc/cp/pt.cc
gcc/testsuite/g++.dg/concepts/explicit-spec1a.C [new file with mode: 0644]