[libc++] ADL-proof by adding _VSTD:: qualifications to memmove etc.
authorArthur O'Dwyer <arthur.j.odwyer@gmail.com>
Tue, 8 Dec 2020 02:50:15 +0000 (21:50 -0500)
committerArthur O'Dwyer <arthur.j.odwyer@gmail.com>
Fri, 11 Dec 2020 03:03:12 +0000 (22:03 -0500)
commit3696227c10f5e5841223c2a2fb63fdd1d50a7930
tree5fc26839ee101f7bcbe0e77d3d20f07dcd50640a
parentb12ea0652129da3b42642a0b76adbfab8833db53
[libc++] ADL-proof by adding _VSTD:: qualifications to memmove etc.

Generally these calls aren't vulnerable to ADL because they involve only
primitive types. The ones in <list> and <vector> drag in namespace std
but that's OK; the ones in <fstream> and <strstream> are vulnerable
iff `CharT` is an enum type, which seems far-fetched.
But absolutely zero of them *need* ADL to happen; so in my opinion
they should all be consistently qualified, just like calls to any
other (non-user-customizable) functions in namespace std.

Also: Include <cstring> and <cwchar> in <__string>.
We seemed to be getting lucky that <memory> included <iterator>
included <iosfwd> included <wchar.h>. That gave us the
global-namespace `wmemmove`, but not `_VSTD::wmemmove`.
This is now fixed.

I didn't touch these headers:
<ext/__hash> uses strlen, safely
<support/ibm/locale_mgmt_aix.h> uses memcpy, safely
<string.h> uses memchr and strchr, safely
<wchar.h> uses wcschr, safely
<__bsd_locale_fallbacks.h> uses wcsnrtombs, safely

Differential Revision: https://reviews.llvm.org/D93061
libcxx/include/__hash_table
libcxx/include/__locale
libcxx/include/__string
libcxx/include/atomic
libcxx/include/fstream
libcxx/include/list
libcxx/include/locale
libcxx/include/string
libcxx/include/strstream
libcxx/include/vector