x86: remove __range_not_ok()
authorArnd Bergmann <arnd@arndb.de>
Tue, 15 Feb 2022 08:15:57 +0000 (09:15 +0100)
committerArnd Bergmann <arnd@arndb.de>
Fri, 25 Feb 2022 08:36:05 +0000 (09:36 +0100)
commit36903abedfe8d419e90ce349b2b4ce6dc2883e17
treecd63798d0a25f39afd24fe6872fef92cf0da0cea
parent8afafbc955ba6fc04b1e202b21856020152d12c9
x86: remove __range_not_ok()

The __range_not_ok() helper is an x86 (and sparc64) specific interface
that does roughly the same thing as __access_ok(), but with different
calling conventions.

Change this to use the normal interface in order for consistency as we
clean up all access_ok() implementations.

This changes the limit from TASK_SIZE to TASK_SIZE_MAX, which Al points
out is the right thing do do here anyway.

The callers have to use __access_ok() instead of the normal access_ok()
though, because on x86 that contains a WARN_ON_IN_IRQ() check that cannot
be used inside of NMI context while tracing.

The check in copy_code() is not needed any more, because this one is
already done by copy_from_user_nmi().

Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Suggested-by: Christoph Hellwig <hch@infradead.org>
Link: https://lore.kernel.org/lkml/YgsUKcXGR7r4nINj@zeniv-ca.linux.org.uk/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
arch/x86/events/core.c
arch/x86/include/asm/uaccess.h
arch/x86/kernel/dumpstack.c
arch/x86/kernel/stacktrace.c
arch/x86/lib/usercopy.c