cg3: add extra check to prevent CG3 register array overflow
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Sat, 24 May 2014 10:51:50 +0000 (11:51 +0100)
committerMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Thu, 5 Jun 2014 19:51:30 +0000 (20:51 +0100)
commit366d4f7e0007a5540897fbac6e377c57d8c79a73
tree413fb8f72f65ac9521a570c35347a6c50530593d
parente09c49f40de32620e99f67a71d4508c7fe97dd84
cg3: add extra check to prevent CG3 register array overflow

The case statements in the CG3 read and write register routines have a maximum
value of CG3_REG_SIZE, so if a value were written to this offset then it
would overflow the register array.

Currently this cannot be exploited since the MemoryRegion restricts accesses
to the range 0 ... CG3_REG_SIZE - 1, but it seems worth clarifying this for
future review and/or static analysis.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
CC: Paolo Bonzini <pbonzini@redhat.com>
hw/display/cg3.c