[libc++] [test] Change a lot of free begin/end pairs to members. NFCI.
authorArthur O'Dwyer <arthur.j.odwyer@gmail.com>
Tue, 5 Oct 2021 17:31:59 +0000 (13:31 -0400)
committerArthur O'Dwyer <arthur.j.odwyer@gmail.com>
Wed, 6 Oct 2021 20:43:03 +0000 (16:43 -0400)
commit3666dd795d9e2114e49bd58ace042b663d6f8a3a
tree257dcdbf1e79c327dc9f3c3316983e9f54e43826
parent6522b7cc3240626952ebc271d8714043a805911d
[libc++] [test] Change a lot of free begin/end pairs to members. NFCI.

If you have a `begin() const` member, you don't need a `begin()` member
unless you want it to do something different (e.g. have a different return
type). So in general, //view// types don't need `begin()` non-const members.

Also, static_assert some things about the types in "types.h", so that we
don't accidentally break those properties under refactoring.

Differential Revision: https://reviews.llvm.org/D111231
12 files changed:
libcxx/test/libcxx/ranges/range.utility.helpers/simple_view.compile.pass.cpp
libcxx/test/std/ranges/range.access/range.prim/data.pass.cpp
libcxx/test/std/ranges/range.adaptors/range.all/all.pass.cpp
libcxx/test/std/ranges/range.adaptors/range.common.view/borrowing.compile.pass.cpp
libcxx/test/std/ranges/range.adaptors/range.common.view/ctad.compile.pass.cpp
libcxx/test/std/ranges/range.adaptors/range.common.view/types.h
libcxx/test/std/ranges/range.adaptors/range.drop/types.h
libcxx/test/std/ranges/range.adaptors/range.join.view/types.h
libcxx/test/std/ranges/range.adaptors/range.reverse/types.h
libcxx/test/std/ranges/range.adaptors/range.take/begin.pass.cpp
libcxx/test/std/ranges/range.adaptors/range.take/types.h
libcxx/test/std/ranges/range.adaptors/range.transform/types.h