Clean up some string.Format usage (#23025)
authorStephen Toub <stoub@microsoft.com>
Wed, 6 Mar 2019 03:37:33 +0000 (19:37 -0800)
committerGitHub <noreply@github.com>
Wed, 6 Mar 2019 03:37:33 +0000 (19:37 -0800)
commit3662d02bb222728ebed70d6d73f89a63c9910ffb
tree45ff3f38f517a773aab5a923f1ce55c1afde5252
parentffcdabd7735d6860dec361d1efde20be4cf89b8f
Clean up some string.Format usage (#23025)

* Clean up some string.Format usage

Mainly changes some string.Format usage to be SR.Format when working with resource strings.  Also cleans up a few asserts that were using string.Format.

* Address PR feedback and clean up src

* Address more feedback

* Update src/System.Private.CoreLib/shared/System/Type.Enum.cs

Thanks.

Co-Authored-By: stephentoub <stoub@microsoft.com>
45 files changed:
src/System.Private.CoreLib/Common/System/SR.cs
src/System.Private.CoreLib/System.Private.CoreLib.csproj
src/System.Private.CoreLib/shared/Interop/Unix/Interop.Errors.cs
src/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.GetHostName.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs
src/System.Private.CoreLib/shared/System/ArgumentOutOfRangeException.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/EventPayload.cs
src/System.Private.CoreLib/shared/System/Environment.Variables.Windows.cs
src/System.Private.CoreLib/shared/System/Globalization/CalendarData.Unix.cs
src/System.Private.CoreLib/shared/System/Globalization/DateTimeFormat.cs
src/System.Private.CoreLib/shared/System/Globalization/EastAsianLunisolarCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/GregorianCalendarHelper.cs
src/System.Private.CoreLib/shared/System/Globalization/HebrewCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/HijriCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/NumberFormatInfo.cs
src/System.Private.CoreLib/shared/System/Globalization/RegionInfo.cs
src/System.Private.CoreLib/shared/System/Globalization/UmAlQuraCalendar.cs
src/System.Private.CoreLib/shared/System/Resources/ManifestBasedResourceGroveler.cs
src/System.Private.CoreLib/shared/System/Resources/ResourceManager.cs
src/System.Private.CoreLib/shared/System/Security/CryptographicException.cs
src/System.Private.CoreLib/shared/System/Security/SecurityElement.cs
src/System.Private.CoreLib/shared/System/ThrowHelper.cs
src/System.Private.CoreLib/shared/System/Tuple.cs
src/System.Private.CoreLib/shared/System/Type.Enum.cs
src/System.Private.CoreLib/shared/System/ValueTuple.cs
src/System.Private.CoreLib/src/System/Enum.cs
src/System.Private.CoreLib/src/System/GC.cs
src/System.Private.CoreLib/src/System/IO/FileLoadException.CoreCLR.cs
src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/CustomAttributeBuilder.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilder.cs
src/System.Private.CoreLib/src/System/Reflection/FieldInfo.CoreCLR.cs
src/System.Private.CoreLib/src/System/Reflection/MdImport.cs
src/System.Private.CoreLib/src/System/Reflection/MethodBase.CoreCLR.cs
src/System.Private.CoreLib/src/System/Reflection/RtFieldInfo.cs
src/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs
src/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs
src/System.Private.CoreLib/src/System/Reflection/RuntimeModule.cs
src/System.Private.CoreLib/src/System/RtType.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/CustomPropertyImpl.cs
src/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyDependencyResolver.cs
src/System.Private.CoreLib/src/System/Runtime/Serialization/FormatterServices.cs
src/System.Private.CoreLib/src/System/StubHelpers.cs
src/System.Private.CoreLib/src/System/TypeLoadException.cs