ALSA: usb-audio: Fix potential use-after-free of streams
authorTakashi Iwai <tiwai@suse.de>
Tue, 16 Jun 2020 12:09:21 +0000 (14:09 +0200)
committerSasha Levin <sashal@kernel.org>
Tue, 30 Jun 2020 19:36:47 +0000 (15:36 -0400)
commit3621616af99bac4cf55728265ce886f36e6a3fed
treef95f50f746566f47ea0a242e1ff84eb33747bb35
parent335add4ac891c3c5094e5b30cce004322f284ca4
ALSA: usb-audio: Fix potential use-after-free of streams

[ Upstream commit ff58bbc7b9704a5869204176f804eff57307fef0 ]

With the recent full-duplex support of implicit feedback streams, an
endpoint can be still running after closing the capture stream as long
as the playback stream with the sync-endpoint is running.  In such a
state, the URBs are still be handled and they may call retire_data_urb
callback, which tries to transfer the data from the PCM buffer.  Since
the PCM stream gets closed, this may lead to use-after-free.

This patch adds the proper clearance of the callback at stopping the
capture stream for addressing the possible UAF above.

Fixes: 10ce77e4817f ("ALSA: usb-audio: Add duplex sound support for USB devices using implicit feedback")
Link: https://lore.kernel.org/r/20200616120921.12249-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/usb/pcm.c